Fully replace content of XWPFTableCell on setText
#503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now, invoking `XWPFTableCell#setText(String)` appended the string to a paragraph if one already existed in the cell, contrary to what would be expected. This is fixed in this commit by first removing all runs and iruns from the paragraph in the cell.
pjfanning
reviewed
Aug 17, 2023
poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFTableCell.java
Outdated
Show resolved
Hide resolved
Using `.clear` does not work for the list returned by `getRuns`, so it was rewritten to use the provided `removeRun` method.
|
This broke an existing test called test63624 - I'll rewrite that test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, invoking
XWPFTableCell#setText(String)appended the string to a paragraph if one already existed in the cell, contrary to what would be expected.This is fixed in this commit by first removing all runs and iruns from the paragraph in the cell.
Fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=66988