fix: doCommitOffsets of PulsarKafkaConsumer in version 2.11.0 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eIdImpl in doCommitOffsets method
dlg99
reviewed
May 4, 2023
|
@eolivelli @dlg99 added a unit test for commitSync, specifically on how acknowledgeCumulativeAsync is called inside doCommitOffsets. Let me know if there is any thing else required. |
|
@dlg99, any idea when can this be merged if everything is good? Also, can a patch version be released with this fix ? |
tisonkun
approved these changes
Jun 16, 2023
|
I support to merge this patch. @dlg99 @eolivelli could you give another look? |
tisonkun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48
Master Issue: #48
Motivation
doCommitOffsets method in Pulsar Kafka Client version 2.11.0 is not working for partitioned topics. This does not allows acking messages.
Modifications
In doCommitOffsets PulsarKafkaConsumer.java creating TopicMessageIdImpl with the correct partition name
Verifying this change
This change is already covered by existing tests, provided we create it as a partitioned topic
Does this pull request potentially affect one of the following parts:
Documentation