ci: stablize golangci-lint task

[tisonkun]

This closes #1005.

Modifications

1. Replace the usage of golangci-lint action with barely bin commands.
2. Support run with the specified version with one command make lint and store the binutil project-wise.

Verifying this change

• Make sure that the change passes the CI checks.

Documentation

• Does this pull request introduce a new feature? (yes / no)
• If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
• If a feature is not applicable for documentation, explain why?
• If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

[shibd]

@tisonkun Please help explain why?

[tisonkun]

why

Why for what?

You can refer to the issue for the failure. Generally, we use a v3 tag for golangci-lint action which is not fixed. So anything can be changed from upstream. This patch pinned the golangci-lint to v1.51.2 and does not use the action to ignore any bad case there.

[shibd]

why

Why for what?

You can refer to the issue for the failure. Generally, we use a v3 tag for golangci-lint action which is not fixed. So anything can be changed from upstream. This patch pinned the golangci-lint to v1.51.2 and does not use the action to ignore any bad case there.

FYI, we have fixed the version here.

https://github.com/apache/pulsar-client-go/pull/951/files

[tisonkun]

@shibd Yep. So the problem is that we are using an action that can produce some unpredictable issues, also we can hardly run it locally - said other projects use a different version but either of them installed in $GOBIN/golangci-lint.

[tisonkun]

Merging...

Unblock other PRs.

[Gleiphir2769]

Good work! @tisonkun

But I am very curious why httpclient can pass the previous CI. It has already been introduced in 2021. The old golangci-lint we used has the ability for ignoring old files?

I do not find any golangci-lint doc for this so I can not understand why this happens. This is so weird.

[tisonkun]

But I am very curious why httpclient can pass the previous CI. It has already been introduced in 2021. The old golangci-lint we used has the ability for ignoring old files?

I bump the golangci-lint to 1.51.2 because original 1.50.1 doesn't work locally for unknown reason - I don't spend time to figure it out but simply do a small version bump.

Besides, it's a false positive on bodyclose linter. There are a few false positive reports upstream, like timakin/bodyclose#42.

[Gleiphir2769]

Besides, it's a false positive on bodyclose linter. There are a few false positive reports upstream, like timakin/bodyclose#42.

I see. It's actually a false positive. Thanks!