Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix event time not being set when batching is disabled #1015

Merged
merged 2 commits into from
May 17, 2023

Conversation

RobertIndie
Copy link
Member

Fixes #1013

Motivation

The event time is not set when batching is disabled. The event time will be lost.
This is a regression bug in 0.10.0.

Modifications

  • Set the event time when sending single message

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@RobertIndie RobertIndie added this to the v0.11.0 milestone May 11, 2023
@RobertIndie RobertIndie self-assigned this May 11, 2023
@RobertIndie RobertIndie merged commit 27e3625 into apache:master May 17, 2023
6 checks passed
@RobertIndie RobertIndie deleted the iss-1013 branch May 17, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event time not being set when batching is disabled in producer
2 participants