Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix ordering key not being set and parsed when batching is disabled #1034

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

RobertIndie
Copy link
Member

Motivation

When batching is disabled, the ordering key couldn't be configured and parsed correctly. This is a regression bug.
For the reproducible code, please see the test TestNoBatchSendMessagesWithMetadata in this PR.

Modifications

  • Set the ordering key when publishing a single message
  • Parsed the ordering key when consuming a single message

Verifying this change

This change added tests: TestBatchSendMessagesWithMetadata and TestNoBatchSendMessagesWithMetadata

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@RobertIndie RobertIndie added this to the v0.11.0 milestone Jun 25, 2023
@RobertIndie RobertIndie self-assigned this Jun 25, 2023
@shibd shibd merged commit 3da3e5d into apache:master Jun 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants