Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] refactor duplicated code lines and fix typo errors #1039

Merged
merged 7 commits into from
Jul 3, 2023

Conversation

gunli
Copy link
Contributor

@gunli gunli commented Jun 26, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

There are duplicated code lines and typo errors in producer_partition.go, fix them.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

pulsar/producer_partition.go Outdated Show resolved Hide resolved
pulsar/producer_partition.go Show resolved Hide resolved
@gunli gunli force-pushed the refactor_partitionProducer branch from 4620dac to 76dd0ef Compare June 28, 2023 06:09
Copy link
Member

@shoothzj shoothzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. But I don't think some rename is necessary. Like

  • rename conn to connection
  • rename flag to mark

@gunli gunli requested a review from shibd June 29, 2023 14:26
@gunli
Copy link
Contributor Author

gunli commented Jun 29, 2023

It seems the CI is broken.

pulsar/producer_partition.go Show resolved Hide resolved
@shibd
Copy link
Member

shibd commented Jun 29, 2023

It seems the CI is broken.

The ci failed info:

topic="persistent://public/default/my-topic-651450217"
    transaction_test.go:284: 
        	Error Trace:	/pulsar/pulsar-client-go/pulsar/transaction_test.go:284
        	Error:      	The consumer should not receive uncommitted message
        	Test:       	TestConsumeAndProduceWithTxn

The root cause is you forget to set useTxn = true on here.

#1039 (comment)

@shibd shibd merged commit 5f8df27 into apache:master Jul 3, 2023
6 checks passed
@RobertIndie RobertIndie added this to the v0.11.0 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants