Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Correct the SendAsync() description #1066

Merged
merged 1 commit into from
Jul 27, 2023
Merged

[fix] Correct the SendAsync() description #1066

merged 1 commit into from
Jul 27, 2023

Conversation

Gleiphir2769
Copy link
Contributor

Motivation

After #1029 , eventChan is split into dataChan and cmdChan. But the description of SendAsync() is not modified.

pulsar-client-go/pulsar/producer.go

Lines 226 to 231 in 9867c29

// SendAsync a message in asynchronous mode
// This call is blocked when the `event channel` becomes full (default: 10) or the
// `maxPendingMessages` becomes full (default: 1000)
// The callback will report back the message being published and
// the eventual error in publishing
SendAsync(context.Context, *ProducerMessage, func(MessageID, *ProducerMessage, error))

Modifications

  • Correct the description of SendAsync() description

Verifying this change

  • Make sure that the change passes the CI checks.

@RobertIndie RobertIndie added this to the v0.12.0 milestone Jul 26, 2023
@RobertIndie RobertIndie merged commit 50015d3 into apache:master Jul 27, 2023
6 checks passed
graysonzeng pushed a commit to graysonzeng/pulsar-client-go that referenced this pull request Jul 31, 2023
@Gleiphir2769 @graysonzeng
[fix] Correct the SendAsync() description (apache#1066)
d6b07fe 
### Motivation

After apache#1029 , `eventChan` is split into `dataChan` and `cmdChan`.  But the description of `SendAsync()` is not modified.

https://github.com/apache/pulsar-client-go/blob/9867c29ca329302e97ddd9c6a99f66853c7f447f/pulsar/producer.go#L226-L231

### Modifications

- Correct the description of SendAsync() description
RobertIndie pushed a commit that referenced this pull request Sep 7, 2023
@Gleiphir2769 @RobertIndie
[fix] Correct the SendAsync() description (#1066)
60f2908 
### Motivation

After #1029 , `eventChan` is split into `dataChan` and `cmdChan`.  But the description of `SendAsync()` is not modified.

https://github.com/apache/pulsar-client-go/blob/9867c29ca329302e97ddd9c6a99f66853c7f447f/pulsar/producer.go#L226-L231

### Modifications

- Correct the description of SendAsync() description

(cherry picked from commit 50015d3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertIndie RobertIndie RobertIndie approved these changes

Assignees

@Gleiphir2769 Gleiphir2769

Labels
area/producer cherry-picked/branch-0.11.0 release/0.11.1 type/enhancement
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gleiphir2769 @RobertIndie