Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Add optional parameters for getPartitionedStats #1193

Merged
merged 6 commits into from Mar 5, 2024

Conversation

crossoverJie
Copy link
Contributor

Motivation

To keep consistent with the Java client.

Releted PR: apache/pulsar#21611

Modifications

Add GetStatsOptions params.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (yes)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (GoDocs)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Member

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some test cases like testPartitionState and testNonPartitionState?

@crossoverJie
Copy link
Contributor Author

Can you add some test cases like testPartitionState and testNonPartitionState?

I've added, but find that there's a test overtime after upgrading the image to 3.2.0, and I can adjust the sequence to work properly, but this may be a potential bug, I'll try to locate to specific reasons.

Copy link
Member

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. LGTM

@RobertIndie RobertIndie merged commit c4f47ab into apache:master Mar 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants