Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 271][Producer]Stop partition discovery on Close #272

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

dvergnes
Copy link
Contributor

@dvergnes dvergnes commented Jun 9, 2020

Fixes #271

Motivation

This fixes a race when a producer is closed and the number of partitions changed i.e. the topic is deleted just after the producer is closed.

Modifications

It consists of stopping the ticker that controls the partition discovery in the background.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This is a trivial rework.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? no

@dvergnes dvergnes changed the title [Issue 271][Producer]Fixes #271: Stop partition discovery on Close [Issue 271][Producer]Stop partition discovery on Close Jun 9, 2020
@merlimat merlimat merged commit 9ed8af8 into apache:master Jun 9, 2020
@wolfstudy wolfstudy added this to the 0.1.1 milestone Jun 9, 2020
@dvergnes dvergnes deleted the stop-ticker-on-close branch June 28, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partition discovery is still running after calling producer.Close
3 participants