-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support producer name for Message #299
Conversation
Signed-off-by: xiaolong.ran <rxl@apache.org>
@merlimat Hello, currently, the Jenkinns CI still running, Do we need to do anything else for this? |
@JoseFMP PTAL thanks |
Signed-off-by: xiaolong.ran <rxl@apache.org>
Signed-off-by: xiaolong.ran <rxl@apache.org>
pulsar/message.go
Outdated
@@ -64,6 +64,9 @@ type Message interface { | |||
// Topic get the topic from which this message originated from | |||
Topic() string | |||
|
|||
// ProducerName will get producer name from broker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saying "from broker" can be misleading since we're not fetching it from the broker, rather the name comes attached to the message metadata.
In Java client doc we have:
Get the producer name who produced this message.
// ProducerName will get producer name from broker | |
// ProducerName returns the name of the producer that has published the message |
Signed-off-by: xiaolong.ran <rxl@apache.org>
Signed-off-by: xiaolong.ran <rxl@apache.org>
Signed-off-by: xiaolong.ran rxl@apache.org
Fixes #295
Motivation
Support producer name for Message interface, allows the user to get the
producerName
of the message in the received message.Modifications
producerName
filed tomessage
struct