[Issue 306] Change connection failed warn log to error and print error message #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfstudy
requested changes
Jul 6, 2020
wolfstudy
reviewed
Jul 6, 2020
pulsar/internal/connection.go
Outdated
| @@ -287,8 +287,8 @@ func (c *connection) doHandshake() bool { | |||
| c.cnx.SetDeadline(time.Time{}) | |||
|
|
|||
| if cmd.Connected == nil { | |||
| c.log.Warnf("Failed to perform initial handshake - Expecting 'Connected' cmd, got '%s'", | |||
| cmd.Type) | |||
| c.log.Errorf("Failed to perform initial handshake - Expecting 'Connected' cmd, got '%s'", | |||
There was a problem hiding this comment.
About log level I think Warnf is more appropriate, it has not reached the Error level
There was a problem hiding this comment.
Thanks for your code review!
How do we define the error level ? The client can't working when this error happend and why just got warn log?
There was a problem hiding this comment.
The message itself need to be changed though. It was basically a "debug" message. In this case, the user doesn't know what's a Connected cmd.
merlimat
reviewed
Jul 7, 2020
| @@ -288,7 +288,7 @@ func (c *connection) doHandshake() bool { | |||
|
|
|||
| if cmd.Connected == nil { | |||
| c.log.Warnf("Failed to perform initial handshake - Expecting 'Connected' cmd, got '%s'", | |||
| cmd.Type) | |||
| cmd.Error.GetMessage()) | |||
There was a problem hiding this comment.
Please change the original message since with this change it wouldn't make sense anymore:
c.log.Warnf("Failed to establish connection with broker: '%s'",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Print a clean log when the connection failed.