Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default router to switch partition on all batching thresholds … #383

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

dvergnes
Copy link
Contributor

@dvergnes dvergnes commented Oct 20, 2020

Master Issue: #382

Motivation

The default router only switches partition when the max delay to publish has elapsed. This PR is about switching as soon as one of the threshold (max number of messages, max number of bytes, max delay) is reached.

Modifications

The default router has been updated to switch when one of the threshold is reached. To prevent cyclic dependencies between the packages, it has been moved from internal to pulsar package.

Verifying this change

  • [X ] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change added unit tests to verify all cases

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? GoDocs

@wolfstudy wolfstudy added this to the 0.3.0 milestone Oct 21, 2020
@wolfstudy wolfstudy merged commit 16fea6d into apache:master Oct 21, 2020
@dvergnes dvergnes deleted the vergnes/default-router branch June 28, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants