Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue #379][pulsar-client-go] Replaced github.com/DataDog/zstd with github.com/datadog/zstd #385

Merged
merged 1 commit into from
Oct 28, 2020
Merged

[Issue #379][pulsar-client-go] Replaced github.com/DataDog/zstd with github.com/datadog/zstd #385

merged 1 commit into from
Oct 28, 2020

Conversation

omnilight
Copy link
Contributor

Fixes #379

Motivation

Using DataDog instead of datadog is not canonical way

Modifications

Changed dependency nam

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)
  • If a feature is not applicable for documentation, explain why? Just library name change

Replaced github.com/DataDog/zstd with github.com/datadog/zstd
584bf0d 
Signed-off-by: Pavel Agaletskiy <psagaletskiy@avito.ru>
@merlimat merlimat merged commit 793ea91 into apache:master Oct 28, 2020
@wolfstudy wolfstudy added this to the 0.3.0 milestone Oct 29, 2020
@omnilight omnilight deleted the normalize_datadog_dependency branch October 29, 2020 05:19
@dunglas dunglas mentioned this pull request Jan 14, 2021
Closed
@sijie sijie mentioned this pull request Jan 14, 2021
Closed
@uiot-stack uiot-stack mentioned this pull request Jun 10, 2021
Open
@sijie sijie mentioned this pull request Jun 10, 2021
Open
@dr-dime
Copy link

dr-dime commented Jul 6, 2022

This is completely wrong. DataDog/zstd claims itself as
github.com/DataDog/zstd. See: https://github.com/DataDog/zstd/blob/1.x/go.mod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

Assignees

@omnilight omnilight

Labels
type/enhancement
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Problem with github.com/DataDog/zstd
4 participants
@omnilight @dr-dime @merlimat @wolfstudy