Add metric for internal publish latency #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Nov 19, 2020
wolfstudy
approved these changes
Nov 20, 2020
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
…o#246) (apache#397) Add command topic Message Dispatch Rate: > Pulsarctl does not support 2-letter shorthand, so use the full length. - pulsarctl topics get-dispatch-rate [topic] - pulsarctl topics set-dispatch-rate [topic] --msg-dispatch-rate 1 --byte-dispatch-rate 2 --dispatch-rate-period 3 --relative-to-publish-rate - pulsarctl topics remove-dispatch-rate [topic]
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
…apache#397) Add command topic Message Dispatch Rate: > Pulsarctl does not support 2-letter shorthand, so use the full length. - pulsarctl topics get-dispatch-rate [topic] - pulsarctl topics set-dispatch-rate [topic] --msg-dispatch-rate 1 --byte-dispatch-rate 2 --dispatch-rate-period 3 --relative-to-publish-rate - pulsarctl topics remove-dispatch-rate [topic]
tisonkun
pushed a commit
that referenced
this pull request
Aug 16, 2023
…#397) Add command topic Message Dispatch Rate: > Pulsarctl does not support 2-letter shorthand, so use the full length. - pulsarctl topics get-dispatch-rate [topic] - pulsarctl topics set-dispatch-rate [topic] --msg-dispatch-rate 1 --byte-dispatch-rate 2 --dispatch-rate-period 3 --relative-to-publish-rate - pulsarctl topics remove-dispatch-rate [topic]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current publish latency metric measures the time when send is called until the message is acked. The metric can be skewed if batching is enabled.
For example, if we call send the client will hold that message until x number of messages are collected or an interval has passed. This new metric measures the time when we send the data to the connection until we get an ack from the broker. This cuts out any batch skewing and provides a more accurate latency of what the client sees at the connection level.