Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support jwt and trusted cert for pulsar perf client #428

Merged
merged 2 commits into from
Jan 4, 2021

Conversation

zzzming
Copy link
Contributor

@zzzming zzzming commented Dec 22, 2020

Motivation

Add token/JWT and trusted certificate support in Pulsar perf go client. So that it can be used in production environment.

Modifications

Implement pulsar-perf-go command line arguments for token-file and trusted-cert-file. These two arguments are optional. There is no change to the default non-TLS and no auth configuration.

Verifying this change

This is a change to Pulsar perf go client. It should pass build and existing test cases.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@zzzming zzzming changed the title support token and trust cert for pulsar perf client support jwt and trusted cert for pulsar perf client Dec 22, 2020
perf/pulsar-perf-go.go Outdated Show resolved Hide resolved
@wolfstudy wolfstudy added this to the 0.4.0 milestone Jan 4, 2021
@wolfstudy wolfstudy merged commit 71cc54f into apache:master Jan 4, 2021
@zzzming zzzming deleted the perfToken branch January 26, 2021 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants