Fix reader with start latest message id inclusive (#329) #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
force-pushed
the
master
branch
4 times, most recently
from
6f661bc
to
77e7fff
Compare
Fixes apache#356 Fixes apache#419 Motivtions The changes made by the original PR apache#329 are no longer works. This PR is trying to fix the bugs and make the test case be more robust. Moditications * fix the wrong comparison `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))` * fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop * make the `TestReaderLatestInclusiveHasNext` test case be more robust
rueian
force-pushed
the
master
branch
4 times, most recently
from
dc9ae3e
to
f6d4939
Compare
sijie
approved these changes
Feb 17, 2021
wolfstudy
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #356
Fixes #419
Motivtions
The changes made by the original PR #329 are no longer works.
This PR is trying to fix the bugs and make the test case be more robust.
Moditications
pc.startMessageID == lastestMessageIDwithpc.startMessageID.equal(lastestMessageID.(messageID))pc.requestSeek(msgID.messageID)withpc.requestSeekWithoutClear(msgID.messageID)before the dispatch loopTestReaderLatestInclusiveHasNexttest case be more robustVerifying this change
This change is already covered by existing tests, such as
TestReaderLatestInclusiveHasNext.Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation