Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: batch flush method #476

Merged
merged 1 commit into from
Mar 5, 2021
Merged

fix: batch flush method #476

merged 1 commit into from
Mar 5, 2021

Conversation

jonyhy96
Copy link
Contributor

Fixes #475

Motivation

Fix wrong batch flush method bug.

Modifications

Check if batchBuilder is multi batches before flush.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? GoDocs

Signed-off-by: jonyhy96 <hy352144278@gmail.com>
@jonyhy96
Copy link
Contributor Author

/cc @wolfstudy @freeznet

@jonyhy96
Copy link
Contributor Author

There is a data race happens in the ci test. Should i fix it before merged or we could issue another pr for this?

@freeznet
Copy link
Contributor

freeznet commented Mar 2, 2021

There is a data race happens in the ci test. Should i fix it before merged or we could issue another pr for this?

i think we should fix the ci test issue in another pr.

@wolfstudy
Copy link
Member

wolfstudy commented Mar 5, 2021

There is a data race happens in the ci test. Should i fix it before merged or we could issue another pr for this?

Thanks @jonyhy96 work for this, please fix the ci error or send new pull request to fix this, thanks.

And please make sure to create one issue to track this, thanks.

@wolfstudy wolfstudy added this to the 0.5.0 milestone Mar 5, 2021
@wolfstudy wolfstudy self-requested a review March 5, 2021 05:29
@jonyhy96
Copy link
Contributor Author

jonyhy96 commented Mar 5, 2021

There is a data race happens in the ci test. Should i fix it before merged or we could issue another pr for this?

Thanks @jonyhy96 work for this, please fix the ci error or send new pull request to fix this, thanks.

And please make sure to create one issue to track this, thanks.

The ci error is not caused by this pr. Maybe someone else can fix it.

@jonyhy96
Copy link
Contributor Author

jonyhy96 commented Mar 5, 2021

The data race condition in ci test happens occasionally, as we can see the checks of this pr is all passed 😅
I issued this problem in #483.
/cc @freeznet @wolfstudy

@wolfstudy
Copy link
Member

Cool Thanks @jonyhy96

@wolfstudy wolfstudy merged commit cd210a1 into apache:master Mar 5, 2021
@jonyhy96 jonyhy96 deleted the fix-internalsend branch March 5, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyBasedBatchBuilder not work in perf code
4 participants