Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 177] add multiple hosts support #484

Merged
merged 7 commits into from
Mar 9, 2021
Merged

[Issue 177] add multiple hosts support #484

merged 7 commits into from
Mar 9, 2021

Conversation

freeznet
Copy link
Contributor

@freeznet freeznet commented Mar 5, 2021

Fixes #177

Master Issue apache/pulsar#3218

Motivation

add multiple hosts support to go client

Modifications

  • add service uri & service name resolver
  • add service name resolver to lookup service & rpc client
  • add unit tests
  • add integration tests

Verifying this change

  • Make sure that the change passes the CI checks.

@freeznet
Copy link
Contributor Author

freeznet commented Mar 5, 2021

@wolfstudy PTAL, thanks

@wolfstudy wolfstudy assigned wolfstudy and freeznet and unassigned wolfstudy Mar 5, 2021
@wolfstudy wolfstudy added this to the 0.5.0 milestone Mar 5, 2021
wolfstudy
wolfstudy reviewed Mar 5, 2021
View reviewed changes
Copy link
Member

@wolfstudy wolfstudy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic LGTM +1, @freeznet please merge master code and fix conflict

@wolfstudy
Copy link
Member

@merlimat @cckellogg please review this change, thanks.

@freeznet freeznet force-pushed the issue-177-add-multiple-hosts-support branch from e0436f9 to 65b50c4 Compare March 5, 2021 14:59
@wolfstudy wolfstudy merged commit 5fb7f55 into apache:master Mar 9, 2021
@freeznet freeznet mentioned this pull request Mar 9, 2021
Closed
7 tasks
@Anonymitaet
Copy link
Member

@freeznet I've added docs for this PR, could u pls help review? Feedback b4 3/24 is highly appreciated, thanks.

@Anonymitaet Anonymitaet mentioned this pull request Mar 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfstudy wolfstudy wolfstudy approved these changes

@merlimat merlimat Awaiting requested review from merlimat

Assignees

@freeznet freeznet

Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Not support multi pulsar cluster addresses
3 participants
@freeznet @wolfstudy @Anonymitaet