[Issue 491][rpc_client]fix: timeout guarantee for RequestOnCnx #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jonyhy96 <hy352144278@gmail.com>
wolfstudy
reviewed
Mar 26, 2021
| rpcResult := &RPCResult{ | ||
| Cnx: cnx, | ||
| } | ||
| ch := make(chan result, 1) |
There was a problem hiding this comment.
Can we consider adjusting the size of the channel buffer appropriately? It looks like 10 is a good choice?
There was a problem hiding this comment.
0 maybe enough for this because there will be only one result sends to ch . Set it to 1 to prevent block happens on the sender side.
|
@wolfstudy @jonyhy96 Hi. Could we proceed with this PR? Lack of the timeout on connection is a problem causing locking producer, would be great if we can release this fix |
|
ping @wolfstudy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #491
Motivation
see #491
Modifications
add timeout guarantee to RequestOnCnx
Verifying this change
Does this pull request potentially affect one of the following parts:
Documentation