Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 493] close cnxPool when closing a Client #494

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

XuanYang-cn
Copy link
Contributor

@XuanYang-cn XuanYang-cn commented Mar 26, 2021

<--

Contribution Checklist

  • Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where XYZ should be replaced by the actual issue number.
    Skip Issue XYZ if there is no associated github issue for this pull request.
    Skip component if you are unsure about which is the best component. E.g. [docs] Fix typo in produce method.

  • Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.

  • Each pull request should address only one issue, not mix up code from multiple issues.

  • Each commit in the pull request has a meaningful commit message

  • Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.

(The sections below can be removed for hotfixes of typos)
-->

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #493

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@XuanYang-cn XuanYang-cn changed the title [Issue 493] [Issue 493] close cnxPool when closing a Client Mar 26, 2021
@wolfstudy wolfstudy added this to the 0.5.0 milestone Mar 26, 2021
@wolfstudy wolfstudy self-requested a review March 26, 2021 07:22
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy
Copy link
Member

@XuanYang-cn Thanks your work for this, Is it convenient to explain this pull request comment?

@XuanYang-cn
Copy link
Contributor Author

XuanYang-cn commented Mar 26, 2021

The linked issue #493 explains this PR pretty well,shortly, this PR will release TCP connections after we close the client and prevent goroutine from leaking

@merlimat merlimat merged commit 4d6c151 into apache:master Mar 26, 2021
@XuanYang-cn XuanYang-cn deleted the fix-#493 branch March 27, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants