Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add open tracing to pulsar go clinet #518

Merged
merged 5 commits into from Jul 12, 2021

Conversation

maraiskruger1980
Copy link
Contributor

As suggested by @sijie
image

Here is the PR to add open tracing to the pulsar go client directly.
This is replicating what the java tracer does:
https://github.com/streamnative/pulsar-tracing
The usage is stipulated in the readme.md file

Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maraiskruger1980 Great Job., thanks for your contribution. Can you add some test cases for this?

It seems that we can also add similar functions to the reader. Are you also interested in this?

@wolfstudy
Copy link
Member

It seems that we can also add similar functions to the reader. Are you also interested in this?

For this, you can also send a new pull request to impl it.

@maraiskruger1980
Copy link
Contributor Author

@maraiskruger1980 Great Job., thanks for your contribution. Can you add some test cases for this?

It seems that we can also add similar functions to the reader. Are you also interested in this?

@wolfstudy I added tests and made some improvements

Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy
Copy link
Member

Here is the PR to add open tracing to the pulsar go client directly.
This is replicating what the java tracer does:
https://github.com/streamnative/pulsar-tracing
The usage is stipulated in the readme.md file

@wolfstudy wolfstudy merged commit 0de4792 into apache:master Jul 12, 2021
@@ -0,0 +1,40 @@
### Usage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maraiskruger1980 thanks for your contribution! Want users to know this great feature and know how to use it?

If so, could you please add docs to Pulsar - Go client?
(How about adding a section "Monitoring" and add the docs under that section? Explanations of "What is the feature" & "How to use the feature" are needed. You can take How to trace Pulsar messages with OpenTracing and Jaeger and OpenTracing Pulsar Client as references.

Then I would like to help review. Feel free to ping me if needed, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants