Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue 513] fix batch size limit validation #528

Merged
merged 4 commits into from
Oct 25, 2021

Conversation

zzzming
Copy link
Contributor

@zzzming zzzming commented May 28, 2021

Fixes #513

fix batch size limit validation

Motivation

The current batch size validation is incorrect.

Modifications

The batch max size should be used to compare against the current size. The message should be flushed when the max size is reached.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: ( no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@wolfstudy
Copy link
Member

@zzzming Thanks work for this, the change LGTM +1, please fix CI error.

Copy link
Contributor

@freeznet freeznet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfstudy
Copy link
Member

@zzzming Any update for this change?

@wolfstudy
Copy link
Member

Please merge master code and fix CI error, thanks.

@wolfstudy wolfstudy modified the milestones: 0.6.0, 0.7.0 Jul 21, 2021
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzzming please merge master code and fix conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BatchingMaxMessages option is ignored
3 participants