add LedgerId,EntryId,BatchIdx,PartitionIdx func for MessageId interface #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfstudy
reviewed
Jun 1, 2021
There was a problem hiding this comment.
Thanks @yorkhellen work for this, the change LGTM +1, just a little comments, please check?
pulsar/impl_message_test.go
Outdated
| assert.Equal(t, int64(2), id2.EntryId()) | ||
| assert.Equal(t, int32(3), id2.BatchIdx()) | ||
| assert.Equal(t, int32(4), id2.PartitionIdx()) | ||
|
|
There was a problem hiding this comment.
Please do not cover the current function in the original test case. Can you add a new test case to cover this feature?
wolfstudy
reviewed
Jun 1, 2021
pulsar/impl_message_test.go
Outdated
| "github.com/stretchr/testify/assert" | ||
| "testing" |
There was a problem hiding this comment.
Here go's ci check should fail, please make sure that Action CI is passable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, consumers need to obtain the ledgerId, entryId, batchId, partitionidx of the messageId.
This expose LedgerId EntryId BatchId PartitionIdx func for MessageId interface.