Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible race condition in connection pool #561

Merged
merged 2 commits into from Jul 12, 2021
Merged

Fix possible race condition in connection pool #561

merged 2 commits into from Jul 12, 2021

Conversation

cckellogg
Copy link
Contributor

  • Use mutex instead of sync map in connection pool
  • Create tickers in run function for the connection instead
    of when the connection is created

@cckellogg
Fix possible race condition in connection pool
da740cc 
- Use mutex instead of sync map in connection pool
- Create tickers in run function for the connection instead
of when the connection is created
@cckellogg cckellogg requested a review from wolfstudy July 12, 2021 01:39
@wolfstudy wolfstudy added this to the 0.6.0 milestone Jul 12, 2021
wolfstudy
wolfstudy approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy wolfstudy merged commit 9d864c2 into apache:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfstudy wolfstudy wolfstudy approved these changes

Assignees

@cckellogg cckellogg

Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cckellogg @wolfstudy