Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConsumersOpened counter not incremented when use multitopic or regexp consumer #619

Merged

Conversation

PowerStateFailure
Copy link
Contributor

@PowerStateFailure PowerStateFailure commented Sep 25, 2021

Motivation

There was a kind of weird behavior when internal consumers created by multitopic- or regexp consumer are not counted as opened, but do as closed, so we can see in Prometheus that there were more consumers closed than opened.

Modifications

Drop topicSubscribe function, increment ConsumersOpened counter on each success newInternalConsumer call similary to what's already done in reader and producer constructors.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Fix weird behavior when internal consumers created by multitopic- or regexp consumer are not counted as opened, but do as closed, so we can see in Prometheus that there were more consumers closed than opened.
@cckellogg
Copy link
Contributor

LGTM any idea why CI is failing?

@wolfstudy
Copy link
Member

ping @PowerStateFailure please merge master code and fix Action CI

Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy
Copy link
Member

ping @PowerStateFailure please merge master code and fix the action CI, thanks.

@wolfstudy wolfstudy merged commit 44d6b16 into apache:master Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants