Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new bug-resistant build constraints #670

Merged
merged 1 commit into from Nov 30, 2021

Conversation

reugn
Copy link
Contributor

@reugn reugn commented Nov 23, 2021

Motivation

According to the Bug-resistant build constraints proposal, //+build will be replaced by //go:build. A transition period from //+build to //go:build syntax will last from Go version 1.16 through version 1.18.

Verifying this change

  • Make sure that the change passes the CI checks.

Copy link
Contributor

@cckellogg cckellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this can be a separate PR. Should we drop these classes http_client_go_1.11.go and http_client_go_1.12.go? The README now says go 1.13+ is required.

@cckellogg cckellogg merged commit 53d9c28 into apache:master Nov 30, 2021
@reugn reugn deleted the build_constraints branch January 14, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants