Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscription properties for ConsumerOptions #671

Merged
merged 1 commit into from Nov 29, 2021

Conversation

wolfstudy
Copy link
Member

Signed-off-by: xiaolongran xiaolongran@tencent.com

Motivation

In apache/pulsar#12869, we introduce pluggable entry filter in Dispatcher, the pull request is the Go SDK implementation of this PIP

Modifications

Describe the modifications you've done.

  • Add subscription properties for ConsumerOptions
  • Update pulsarApi.proto file

Signed-off-by: xiaolongran <xiaolongran@tencent.com>
@wolfstudy wolfstudy added this to the v0.8.0 milestone Nov 29, 2021
@wolfstudy wolfstudy self-assigned this Nov 29, 2021
@wolfstudy
Copy link
Member Author

In this pull request, i don't add unit test case for this, because I have no way to get the corresponding indicator information from SubscriptionStats. So in apache/pulsar#12979, we added this indicator information to SubscriptionStats, but this needs to wait until a new release containing this pr is released, and we update the Broker used by the Go SDK synchronously The version can be tested accordingly

@wolfstudy
Copy link
Member Author

So, here I opened an issue to track the status of this pr.#672

@wolfstudy wolfstudy merged commit 6385727 into apache:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants