Add subscription properties for ConsumerOptions #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiaolongran <xiaolongran@tencent.com>
|
In this pull request, i don't add unit test case for this, because I have no way to get the corresponding indicator information from SubscriptionStats. So in apache/pulsar#12979, we added this indicator information to SubscriptionStats, but this needs to wait until a new release containing this pr is released, and we update the Broker used by the Go SDK synchronously The version can be tested accordingly |
|
So, here I opened an issue to track the status of this pr.#672 |
zymap
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiaolongran xiaolongran@tencent.com
Motivation
In apache/pulsar#12869, we introduce pluggable entry filter in Dispatcher, the pull request is the Go SDK implementation of this PIP
Modifications
Describe the modifications you've done.
pulsarApi.protofile