Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DefaultRouter] add a parallel bench test #693

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

dferstay
Copy link
Contributor

Motivation

The default router is called for every message published in the default configuration. Therefore, it must maintain a high level of performance in the face of code changes. Previously, we had a benchmark that measured serial routing performance, but we didn't have a way to measure performance of the router under parallel routing calls.

Modifications

Added a BenchmarkDefaultRouterParallel bench test case to default_router_bench_test.go module.

Verifying this change

I ran the default router bench test module by hand from the pulsar sub-directory:

$ go test  -bench="^BenchmarkDefaultRouterParallel$"  -count=10 -cpu=1,2,4,8,16 -run=^$

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): No
  • The public API: No
  • The schema: No
  • The default values of configurations: No
  • The wire protocol: No

Documentation

  • Does this pull request introduce a new feature? No

So that we can verify whether changes to the DefaultRouter have an impact
on performance under concurrent load.

Signed-off-by: Daniel Ferstay <dferstay@splunk.com>
@wolfstudy wolfstudy added this to the v0.8.0 milestone Dec 28, 2021
@dferstay dferstay changed the title Add a parallel default_router bench test [DefaultRouter] add a parallel bench test Dec 28, 2021
@cckellogg cckellogg merged commit 6d543c6 into apache:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants