Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue 679][oauth2] Fix macos compiler warnings #719

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

pgier
Copy link
Contributor

@pgier pgier commented Jan 26, 2022

This upgrades the dependency from the oauth2 module to 99designs/keyring to remove the compiler warnings on macos.

Fixes #679
Fixes #626
Fixes #594

See also 99designs/keyring#102

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Building on recent versions of OSX/MacOS outputs the following compiler warnings.

cgo-gcc-prolog:81:11: warning: 'SecKeychainCreate' is deprecated: first deprecated in macOS 12.0 - Custom keychain management is no longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:301:10: note: 'SecKeychainCreate' has been explicitly marked deprecated here
cgo-gcc-prolog:139:11: warning: 'SecKeychainLock' is deprecated: first deprecated in macOS 12.0 - Custom keychain management is no longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:357:10: note: 'SecKeychainLock' has been explicitly marked deprecated here
cgo-gcc-prolog:159:11: warning: 'SecKeychainOpen' is deprecated: first deprecated in macOS 12.0 - Custom keychain management is no longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:287:10: note: 'SecKeychainOpen' has been explicitly marked deprecated here
cgo-gcc-prolog:183:11: warning: 'SecKeychainUnlock' is deprecated: first deprecated in macOS 12.0 - Custom keychain management is no longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:347:10: note: 'SecKeychainUnlock' has been explicitly marked deprecated here
cgo-gcc-prolog:203:11: warning: 'SecTrustedApplicationCreateFromPath' is deprecated: first deprecated in macOS 10.15 - No longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecTrustedApplication.h:59:10: note: 'SecTrustedApplicationCreateFromPath' has been explicitly marked deprecated here

Modifications

The warnings are coming from the dependency on 99designs/keyring. This PR upgrades to the latest master of that project in order to remove the compiler warnings, and avoid some potential build failures as described in #679

Verifying this change

  • [ X ] Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes)

Documentation

  • Does this pull request introduce a new feature? (no)

This upgrades the 99designs/keyring dependency to v1.2.0
in the oauth2 submodule in order to
remove the compiler deprecation warnings on macos.

Signed-off-by: Paul Gier <paul.gier@datastax.com>
@mihaitodor
Copy link

Thank you for submitting this PR! Hope it can be merged soon, since other downstream projects are facing build errors because of this issue.

@llqgit
Copy link

llqgit commented Feb 25, 2022

I have studied the source code of pulsar OAuth2 sub mod project.
I found that the "store" implements with TWO way, one is memory mode that is using, another is keyring mode that not used at all.
But the warning with macOS is because of the keyring implement that not used.
So I wonder could I remove it once for all?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants