Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema support to Reader #741

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Conversation

ZiyaoWei
Copy link
Contributor

@ZiyaoWei ZiyaoWei commented Mar 7, 2022

Master Issue: #344

Motivation

#368 adds support for schemas in consumer and producer, but didn't add the corresponding option to reader. This fixes that.

Modifications

Add schema field to ReaderOptions and pass the value to the consumer so messages can be read with a schema.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

go test -run ^TestReaderWithSchema$ ./pulsar

Does this pull request potentially affect one of the following parts:

  • The public API: yes

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? GoDoc

@shoothzj
Copy link
Member

@ZiyaoWei #748 is fixed, you can rebase the code for retrigger the ci

Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wolfstudy wolfstudy merged commit 4f50a67 into apache:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants