Cleanup topics after unit tests #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZiyaoWei
force-pushed
the
unit-test-topic-cleanup
branch
from
a456a8c
to
015bc87
Compare
shoothzj
approved these changes
Mar 30, 2022
merlimat
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently a few of the test topics aren't cleaned up after use, so if the same test is ran twice topic creation would fail.
Modifications
defertopic cleanup in unit tests.Verifying this change
This change is already covered by existing tests. For example, before the change,
go test -timeout 5s -run ^TestHTTPTopicPartitions$ github.com/apache/pulsar-client-go/pulsar -count=2would fail, and now it would pass.
Documentation