Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 779]Fix ack request not set requestId when enable AckWithResponse option #780

Merged
merged 1 commit into from
May 27, 2022

Conversation

redlsz
Copy link
Contributor

@redlsz redlsz commented May 27, 2022

Fixes #779

Motivation

Fix bug in #779

Modifications

Set requestId int the ack request command when the AckWithResponse option is enabled.

@wolfstudy wolfstudy self-requested a review May 27, 2022 17:19
@wolfstudy wolfstudy added this to the v0.9.0 milestone May 27, 2022
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, LGTM+1

@wolfstudy wolfstudy merged commit 15136a7 into apache:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ack request not set requestId when enable AckWithResponse option
2 participants