Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix schema error #823

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

leizhiyuan
Copy link
Contributor

@leizhiyuan leizhiyuan commented Aug 7, 2022

Fixes apache/pulsar#16973

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@tisonkun
Copy link
Member

/pulsarbot rerun-failure-checks

@ozgecan
Copy link

ozgecan commented Oct 23, 2023

I have had the same problem and these changes worked for me. Thanks

@tisonkun
Copy link
Member

Thanks for your contribution and verification!

Merging...

@tisonkun tisonkun merged commit f5667b2 into apache:master Oct 23, 2023
@ozgecan
Copy link

ozgecan commented Oct 24, 2023 via email

@tisonkun
Copy link
Member

tisonkun commented Oct 24, 2023

@ozgecan Golang's go.mod should allow you to tag dep with a commit.

For a formal release, I have no idea but at least we need a volunteer to act as the release manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IllegalStateException: Some required fields are missing
3 participants