Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add BackoffPolicy to reader and improve test case #889

Merged
merged 3 commits into from
Nov 11, 2022
Merged

feat: add BackoffPolicy to reader and improve test case #889

merged 3 commits into from
Nov 11, 2022

Conversation

labuladong
Copy link
Contributor

Fixes #872

Modifications

Add BackoffPolicy for ReaderOptions and add tests for BackoffPolicy.

Because Reader uses partitionConsumer, just adding a field in ReaderOptions is enough.

Verifying this change

  • Make sure that the change passes the CI checks.

This change has added tests.

Does this pull request potentially affect one of the following parts:

  • The public API: (yes)
  • The default values of configurations: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@labuladong
Copy link
Contributor Author

PTAL @codelipenghui @frankjkelly @wolfstudy

@frankjkelly
Copy link

LGTM thank you @labuladong

wolfstudy
wolfstudy approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy wolfstudy added this to the v0.10.0 milestone Nov 11, 2022
@wolfstudy wolfstudy merged commit edfb785 into apache:master Nov 11, 2022
@labuladong labuladong deleted the feat-add-backoff branch November 11, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfstudy wolfstudy wolfstudy approved these changes

@freeznet freeznet Awaiting requested review from freeznet

Assignees

@labuladong labuladong

Labels
type/feature
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

ReaderOptions should support BackoffPolicy similar to what was added for ProducerOptions and ConsumerOptions.
3 participants
@labuladong @frankjkelly @wolfstudy