Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][ci] change token name to GITHUB_TOKEN #910

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

labuladong
Copy link
Contributor

Fixes #909

Modifications

Change token to GITHUB_TOKEN.

After changing, the pulsar bot works fine. Example here:

https://github.com/labuladong/pulsar-client-go/actions/runs/3681253024/jobs/6227745474#step:4:27

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Although I suppose we can omit this env var at all and let the action read from preset ENV. But since it works and does no harm, let's move forward with this patch first.

@tisonkun
Copy link
Member

A possible issue is that this default token may not have the write permission required and thus fail to write comment/update status on demand. You can check it (it may work differently from you personal fork and in the upstream) or we just give it a try.

@labuladong
Copy link
Contributor Author

A possible issue is that this default token may not have the write permission required.

I found the bot in the pulsar repo also uses another token:

image

So maybe you are right. I guess the default token doesn't have permission to restart the CI task.

@labuladong
Copy link
Contributor Author

Yes, the behavior in the upstream repo may be different from my fork. So this pr may not work. Do you have any ideas to fix the bug about the CI bot? @tisonkun

@labuladong labuladong marked this pull request as draft December 13, 2022 01:39
@labuladong
Copy link
Contributor Author

@tisonkun tisonkun marked this pull request as ready for review April 14, 2023 09:16
@tisonkun
Copy link
Member

This change doesn't make the case worse. Let's give it a try.

If it still won't work, we can find other approach or just remove the workflow since we actually live well without this functionality always.

@tisonkun tisonkun merged commit 55f0c7c into apache:master Apr 14, 2023
@tisonkun
Copy link
Member

rerun-failed-jobs for 'CI'. Follow progress at https://github.com/apache/pulsar-client-go/actions/runs/2812684476
{
  "message": "Unable to retry this workflow run because it was created over a month ago",
  "documentation_url": "https://docs.github.com/rest/reference/actions#re-run-workflow-failed-jobs"
}
Failed.

https://github.com/apache/pulsar-client-go/actions/runs/4698390864/jobs/8330614311

It seems default token doesn't have enough permission to trigger rerun. Although we can file an INFRA ticket to add one, but IIRC INFRA will reject configure personal access token as we do before - we may be an actual bot account.

I'm OK to leave it as is or delete the workflow file since we can actually live well without this functionality.

@RobertIndie RobertIndie added this to the v0.11.0 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] pulsar bot not work in this repo due to GO_CLIENT_BOT_TOKEN missing
3 participants