Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Setup rate limiter for TestChunksEnqueueFailed to reduce flaky #982

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

RobertIndie
Copy link
Member

Fixes #980

Motivation

The root cause of the flaky test is the producer publishes rate may be too large. This causes the producer doesn't even have enough messages in the publish queue. So there may not be the error producer send queue is full: ProducerQueueIsFull in some case.

Modifications

  • Setup publish rate limiter for the topic in TestChunksEnqueueFailed to reduce flaky.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@RobertIndie RobertIndie self-assigned this Mar 7, 2023
@shibd shibd merged commit 07f97d9 into apache:master Mar 7, 2023
@RobertIndie RobertIndie added this to the v0.10.0 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Test: TestChunksEnqueueFailed
2 participants