[fix]: Fix panic caused by retryAssert()

[Gleiphir2769]

Motivation

retryAssert() will cause panic when assert failed.

For example.

func TestRetryAssert(t *testing.T) {
	retryAssert(t, 5, 200, func() {}, func(t assert.TestingT) bool {
		return assert.Equal(t, 1, 12)
	})
}

Result.

=== RUN   TestRetryAssert
--- FAIL: TestRetryAssert (0.20s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x18 pc=0x1047ffe40]

This is because when assert failed, t.Errorf() will be invoked. However, retryAssert passed a nil value.

pulsar-client-go/pulsar/helper_for_test.go

Line 180 in 04ad521

if assert(nil) {

Modifications

• Fix retryAssert() to avoid panic()

Verifying this change

• Make sure that the change passes the CI checks.