Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Modify the README to apply the new installation method #239

Merged
merged 4 commits into from Nov 27, 2022

Conversation

shibd
Copy link
Member

@shibd shibd commented Oct 31, 2022

Motivation

#235 and #238 support downloading prebuilt binary when npm install. This simplifies installation for users.

Modifications

  • Modify the README to apply the new install and build method.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@shibd
Copy link
Member Author

shibd commented Oct 31, 2022

@merlimat @massakam @AnonHxy Can you take a look? Thanks.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this page! Comments inline.

pkg/mac/common.sh Outdated Show resolved Hide resolved
pkg/mac/common.sh Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@shibd shibd requested a review from tisonkun November 2, 2022 03:45
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait to merge this until the new release is out

@BewareMyPower BewareMyPower merged commit bba4303 into apache:master Nov 27, 2022
@RobertIndie RobertIndie added this to the 1.8.0 milestone Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants