-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]: Support client.getPartitionsForTopic (#320) #322
Conversation
TODO:
|
@XXXMrG Thanks for your contribution. Let's wait for your |
Done. Would you mind giving my code a quick review? @shibd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left some small comments.
@shibd |
Nice, Let's run ci look at it. |
@shibd But I found that the |
Maybe the request body format is invalid. Will cause the partition topic to create failed.
- data: '4',
+ data: 4, |
@shibd Done. let's run ci check again. |
@shibd |
Master Issue: #320
Motivation
Support api: client.getPartitionsForTopic
Modifications
Just bind CPP function:
pulsar_client_get_topic_partitions_async
to JS.Verifying this change
This change added tests and can be verified as follows:
Documentation
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)