Fix #152 Add Helm chart support for Istio port naming (attempt 2) #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
frankjkelly
changed the title
sijie
approved these changes
Sep 9, 2021
1 task
sijie
pushed a commit
that referenced
this pull request
Nov 9, 2021
…t name (#172) Fixes #158 (This is the second PR - see also #162) ### Motivation * All non-standard port-names need a proper protocol prefix to support Istio https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/#explicit-protocol-selection ### Modifications Add the prefix value before `bookie`
pgier
pushed a commit
to pgier/pulsar-helm-chart
that referenced
this pull request
Apr 22, 2022
In our current test logs,we're failing to complete the helm deployment because of this error: ``` ready.go:258: [debug] Service does not have load balancer ingress IP address: pulsar-lzg9asf1t7/pulsar-adminconsole ``` We don't need to test with load balancers. Instead, use ClusterIP to ensure that the targets properly come up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158 (was incorrectly listed as 152)
Motivation
Support prefix in front of port names to abide by Istio protocol rules
https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/#explicit-protocol-selection
Modifications
Support adding a prefix
Verifying this change
NOTE: @lhotari @sijie this is designed to address feedback in #159 - just easier to create a net new PR