Enable persistence for pulsar-manager #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfauth
changed the title
|
The pulsar-manager persistence fix has been merged, so it would be nice if this fix was merged too 😄 |
|
Any chance we can get this merged? LGTM! |
|
@vfauth Thanks for the contribution. Do you have a chance to rebase the changes and ensure that this works with recent versions? |
|
@Mortom123 Please check this PR, is something like this needed after #457? |
|
Yes this is an open issue. However I think it could be quite charming to use the Zookeper as store for the Pulsar-Manager configuration data. @lhotari |
lhotari
force-pushed
the
fix-manager-persistency
branch
from
1353ae6
to
e93f9fa
Compare
|
Thanks for the contribution @vfauth ! This is merged now and will be included in the next release of the chart. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, pulsar-manager volume is not persistent, which means that after a pod restart admin accounts must be recreated every time. I want to change that.
Modifications
Switch pulsar-manager from a Deployment to a StatefulSet and add settings to enable persistence. The settings are inspired by those offered for other components.
Also, the Docker image will always reinitialize the DB, so I made a PR to fix that too.
Verifying this change