Change default value for rbac.limit_to_namespace and functions.rbac.limit_to_namespace #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
michaeljmarshall,
eolivelli,
nicoloboschi and
tisonkun
…imit_to_namespace
lhotari
force-pushed
the
lh-roles-in-namespace-by-default
branch
from
f874616
to
ad7c774
Compare
This was referenced Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The default value is false which uses Cluster level Roles and Rolebindings. This is a bad default since there might not be permissions to have cluster level roles and rolebindings and they don't provide any real value compared to namespace level roles and rolebindings.
Modifications
change the 2 different limit_to_namespace settings from false to true in the values.yaml file.
Other context
This would be released in 3.2.0 and mentioned as a possible breaking change in the release notes.
Verifying this change