Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require helm version 3.10 or newer #436

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jan 18, 2024

Motivation

Installing with helm v3.7.1 fails with this error message:

Error: INSTALLATION FAILED: template: pulsar/templates/broker-statefulset.yaml:270:52: executing
 "pulsar/templates/broker-statefulset.yaml" at <eq .Values.broker.storageOffload.driver "aws-s3">: 
error calling eq: incompatible types for comparison

Modifications

  • Add check that verifies that Helm version is >= 3.10 (Helm 3.10.0 was released in September 2022)
  • Add CI test that verifies that installing the chart works with Helm 3.10.0

Verifying this change

  • Make sure that the change passes the CI checks.

@lhotari lhotari self-assigned this Jan 18, 2024
@frankjkelly
Copy link
Contributor

Thank @lhotari LGTM

@lhotari
Copy link
Member Author

lhotari commented Jan 18, 2024

Thanks for the review @frankjkelly

@lhotari lhotari merged commit e058aa5 into apache:master Jan 18, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants