-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HerdDB database #194
Conversation
eolivelli
commented
Sep 17, 2019
•
edited
Loading
edited
- Add HerdDB JDBC driver (works for tests, accessing a standalone server, accessing a cluster, running the server in the same process of the backend)
- Change all of the DELETE statements to use a syntax supported by Apache Calcite (SQL interpreter of HerdDB)
- Use time_stamp in SQL, and getTimestamp() in beans (there is no way to have a unique sintax to escape keyword 'timestamp' that works for MySQL/HerdDB and PostGre)
- Run tests with HerdDB instead of SQLLite
- add demo configuration for HerdDB
- upgrade Lombok
@tuteng I still have a failing test so this patch is not ready to go. I also have a bad problem with the aliases 'timestamp', that is not supported by Apache Calcite. I am trying to find a fix, byt if you have an idea about how to fix it please chime in cc @sijie |
@eolivelli what is the difference between #183 and this one? |
@sijie I had to start from scratch because of too many conflicts as the schema changes dramatically and so every SQL query was rewritten. |
8b5110b
to
88b1998
Compare
I had to upgrade Lombok in order to make my IDE happy, I can revert that part of the change |
#spring.datasource.password= | ||
|
||
# HerdDB JDBC Driver | ||
spring.datasource.driver-class-name=herddb.jdbc.Driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is now the default
# HerdDB JDBC Driver | ||
spring.datasource.driver-class-name=herddb.jdbc.Driver | ||
HerdDB - local in memory-only (check docs for starting an embedded server or embedded replicated server) | ||
spring.datasource.url=jdbc:herddb:local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is in-memory only
The change looks good to me. @tuteng can you please also take a look? |
@eolivelli Thank you very much for your contribution. There is no problem with the tests on my side. It works very well. Is it convenient for you to add some instructions on the default test database to this document https://github.com/streamnative/pulsar-manager/blob/master/src/README.md? Similar to the following: Default Test database HerdDBIntroductionA brief introduction Document Link: herddb-link |