Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to assign tenant as resource to role #436

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

sourabhaggrawal
Copy link
Contributor

@sourabhaggrawal sourabhaggrawal commented Dec 23, 2021

Motivation

Improve Tenant/Namespace resource assignment workflow.

  • When assigning the resource to a role, it only let you choose from Namespace,SCHEMA,Functions but does not allow the user to select TENANT. A user should have ability to choose tenant for a role and assign the role to a user. Based on which the user should be able to see the tenant it is assigned with.

Modifications

  • changes in this PR include below fixes.
  1. Add TENANT as ResourceType along with Namepsace,Schema etc for Create/Edit Role.
  2. Include only tenants as resource while preparing the response from api /tenants in TenantsController.
  3. In Success LoginResponse, add the tenant as header which is assigned to user's role instead of tenant with user's name.

Verifying this change

  • Make sure that the change passes the ./gradlew build checks.

@sourabhaggrawal
Copy link
Contributor Author

HI @eolivelli @tuteng please take a look

@tuteng tuteng merged commit dfbb19b into apache:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants