Skip to content

Commit

Permalink
Add key_shared advice to Cumulative Ack note (#895)
Browse files Browse the repository at this point in the history
* Add key_shared advice to Cumulative Ack note as mentioned in apache/pulsar/issues/22691
  • Loading branch information
AlvaroStream committed May 10, 2024
1 parent 3a17996 commit 02a9905
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/concepts-messaging.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ consumer.acknowledgeCumulative(msg);

:::note

Cumulative acknowledgment cannot be used in [Shared subscription type](#subscription-types), because Shared subscription type involves multiple consumers which have access to the same subscription. In Shared subscription type, messages are acknowledged individually.
Cumulative acknowledgment cannot be used in [Shared or Key_shared subscription type](#subscription-types), because Shared or Key_Shared subscription type involves multiple consumers which have access to the same subscription. In Shared and Key_Shared subscription types, messages should be acknowledged individually.

:::

Expand Down
2 changes: 1 addition & 1 deletion versioned_docs/version-2.11.x/concepts-messaging.md
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ consumer.acknowledgeCumulative(msg);

:::note

Cumulative acknowledgment cannot be used in [Shared subscription type](#subscription-types), because Shared subscription type involves multiple consumers which have access to the same subscription. In Shared subscription type, messages are acknowledged individually.
Cumulative acknowledgment cannot be used in [Shared or Key_shared subscription type](#subscription-types), because Shared or Key_Shared subscription type involves multiple consumers which have access to the same subscription. In Shared and Key_Shared subscription types, messages should be acknowledged individually.

:::

Expand Down
2 changes: 1 addition & 1 deletion versioned_docs/version-3.0.x/concepts-messaging.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ consumer.acknowledgeCumulative(msg);

:::note

Cumulative acknowledgment cannot be used in [Shared subscription type](#subscription-types), because Shared subscription type involves multiple consumers which have access to the same subscription. In Shared subscription type, messages are acknowledged individually.
Cumulative acknowledgment cannot be used in [Shared or Key_shared subscription type](#subscription-types), because Shared or Key_Shared subscription type involves multiple consumers which have access to the same subscription. In Shared and Key_Shared subscription types, messages should be acknowledged individually.

:::

Expand Down
2 changes: 1 addition & 1 deletion versioned_docs/version-3.2.x/concepts-messaging.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ consumer.acknowledgeCumulative(msg);

:::note

Cumulative acknowledgment cannot be used in [Shared subscription type](#subscription-types), because Shared subscription type involves multiple consumers which have access to the same subscription. In Shared subscription type, messages are acknowledged individually.
Cumulative acknowledgment cannot be used in [Shared or Key_shared subscription type](#subscription-types), because Shared or Key_Shared subscription type involves multiple consumers which have access to the same subscription. In Shared subscription type, messages are acknowledged individually.

:::

Expand Down

0 comments on commit 02a9905

Please sign in to comment.