-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Transaction] Add the batch size in transaction ack command. (#8659)
## Motivation Now in Failover sub we ack with transaction will not get the batch size from consumer pendingAcks, so we should ack request carry the batch size. ## implement We ack with transaction will carry the bath size for individual ack delete the consumer pendingAcks.
- Loading branch information
1 parent
1b790ba
commit 281163b
Showing
21 changed files
with
294 additions
and
114 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74 changes: 74 additions & 0 deletions
74
...n/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleDisabled.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.pulsar.broker.transaction.pendingack.impl; | ||
|
|
||
| import org.apache.bookkeeper.mledger.Position; | ||
| import org.apache.bookkeeper.mledger.impl.PositionImpl; | ||
| import org.apache.commons.lang3.tuple.MutablePair; | ||
| import org.apache.pulsar.broker.service.BrokerServiceException.NotAllowedException; | ||
| import org.apache.pulsar.broker.service.Consumer; | ||
| import org.apache.pulsar.broker.transaction.pendingack.PendingAckHandle; | ||
| import org.apache.pulsar.client.api.transaction.TxnID; | ||
| import org.apache.pulsar.common.util.FutureUtil; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.concurrent.CompletableFuture; | ||
|
|
||
| /** | ||
| * The disabled implementation of {@link PendingAckHandle}. | ||
| */ | ||
| public class PendingAckHandleDisabled implements PendingAckHandle { | ||
|
|
||
| @Override | ||
| public CompletableFuture<Void> individualAcknowledgeMessage(TxnID txnID, | ||
| List<MutablePair<PositionImpl, Integer>> positions) { | ||
| return FutureUtil.failedFuture(new NotAllowedException("The transaction is disabled")); | ||
| } | ||
|
|
||
| @Override | ||
| public CompletableFuture<Void> cumulativeAcknowledgeMessage(TxnID txnID, List<PositionImpl> positions) { | ||
| return FutureUtil.failedFuture(new NotAllowedException("The transaction is disabled")); | ||
| } | ||
|
|
||
| @Override | ||
| public CompletableFuture<Void> commitTxn(TxnID txnID, Map<String, Long> properties) { | ||
| return FutureUtil.failedFuture(new NotAllowedException("The transaction is disabled")); | ||
| } | ||
|
|
||
| @Override | ||
| public CompletableFuture<Void> abortTxn(TxnID txnId, Consumer consumer) { | ||
| return FutureUtil.failedFuture(new NotAllowedException("The transaction is disabled")); | ||
| } | ||
|
|
||
| @Override | ||
| public void syncBatchPositionAckSetForTransaction(PositionImpl position) { | ||
| //no operation | ||
| } | ||
|
|
||
| @Override | ||
| public boolean checkIsCanDeleteConsumerPendingAck(PositionImpl position) { | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public void clearIndividualPosition(Position position) { | ||
| //no operation | ||
| } | ||
| } |
Oops, something went wrong.