-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Branch-2.8] Fix Broker HealthCheck Endpoint Exposes Race Conditions. (…
- Loading branch information
1 parent
0a5d41f
commit 32f8065
Showing
5 changed files
with
237 additions
and
97 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 changes: 91 additions & 0 deletions
91
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiHealthCheckTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.pulsar.broker.admin; | ||
|
|
||
| import com.google.common.collect.Sets; | ||
| import java.util.concurrent.CompletableFuture; | ||
| import java.util.stream.Collectors; | ||
| import org.apache.commons.collections.CollectionUtils; | ||
| import org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest; | ||
| import org.apache.pulsar.client.admin.PulsarAdminException; | ||
| import org.apache.pulsar.common.policies.data.ClusterData; | ||
| import org.apache.pulsar.common.policies.data.TenantInfoImpl; | ||
| import org.apache.pulsar.compaction.Compactor; | ||
| import org.awaitility.Awaitility; | ||
| import org.testng.Assert; | ||
| import org.testng.annotations.AfterMethod; | ||
| import org.testng.annotations.BeforeMethod; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| @Test(groups = "broker") | ||
| public class AdminApiHealthCheckTest extends MockedPulsarServiceBaseTest { | ||
|
|
||
| @BeforeMethod | ||
| @Override | ||
| public void setup() throws Exception { | ||
| resetConfig(); | ||
| super.internalSetup(); | ||
| admin.clusters().createCluster("test", | ||
| ClusterData.builder().serviceUrl(pulsar.getWebServiceAddress()).build()); | ||
| TenantInfoImpl tenantInfo = new TenantInfoImpl( | ||
| Sets.newHashSet("role1", "role2"), Sets.newHashSet("test")); | ||
| admin.tenants().createTenant("pulsar", tenantInfo); | ||
| admin.namespaces().createNamespace("pulsar/system", Sets.newHashSet("test")); | ||
| admin.tenants().createTenant("public", tenantInfo); | ||
| admin.namespaces().createNamespace("public/default", Sets.newHashSet("test")); | ||
| } | ||
| @AfterMethod(alwaysRun = true) | ||
| @Override | ||
| public void cleanup() throws Exception { | ||
| super.internalCleanup(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testHealthCheckup() throws Exception { | ||
| final int times = 30; | ||
| CompletableFuture<Void> future = new CompletableFuture<>(); | ||
| pulsar.getExecutor().execute(() -> { | ||
| try { | ||
| for (int i = 0; i < times; i++) { | ||
| admin.brokers().healthcheck(); | ||
| } | ||
| future.complete(null); | ||
| } catch (PulsarAdminException e) { | ||
| future.completeExceptionally(e); | ||
| } | ||
| }); | ||
| for (int i = 0; i < times; i++) { | ||
| admin.brokers().healthcheck(); | ||
| } | ||
| // To ensure we don't have any subscription | ||
| final String testHealthCheckTopic = String.format("persistent://pulsar/test/localhost:%s/healthcheck", | ||
| pulsar.getConfig().getWebServicePort().get()); | ||
| Awaitility.await().untilAsserted(() -> { | ||
| Assert.assertFalse(future.isCompletedExceptionally()); | ||
| }); | ||
| Awaitility.await().untilAsserted(() -> | ||
| Assert.assertTrue(CollectionUtils.isEmpty(admin.topics() | ||
| .getSubscriptions(testHealthCheckTopic).stream() | ||
| // All system topics are using compaction, even though is not explicitly set in the policies. | ||
| .filter(v -> !v.equals(Compactor.COMPACTION_SUBSCRIPTION)) | ||
| .collect(Collectors.toList()) | ||
| )) | ||
| ); | ||
| } | ||
| } |
Oops, something went wrong.