-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Replicated subscriptions - Advance remote cursor when local consumers…
… moves ahead (#4396) ### Motivation This is the 4th and last (implementation) change for pip-33. It includes reading and caching the last N snapshots and sending the updates to the other clusters. Previous PRs: 1. #4299 2. #4340 3. #4354
- Loading branch information
Showing
10 changed files
with
350 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 changes: 92 additions & 0 deletions
92
...java/org/apache/pulsar/broker/service/persistent/ReplicatedSubscriptionSnapshotCache.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.pulsar.broker.service.persistent; | ||
|
|
||
| import java.util.NavigableMap; | ||
| import java.util.TreeMap; | ||
|
|
||
| import lombok.extern.slf4j.Slf4j; | ||
|
|
||
| import org.apache.bookkeeper.mledger.impl.PositionImpl; | ||
| import org.apache.pulsar.common.api.proto.PulsarMarkers.MessageIdData; | ||
| import org.apache.pulsar.common.api.proto.PulsarMarkers.ReplicatedSubscriptionsSnapshot; | ||
|
|
||
| /** | ||
| * Store the last N snapshots that were scanned by a particular subscription | ||
| */ | ||
| @Slf4j | ||
| public class ReplicatedSubscriptionSnapshotCache { | ||
| private final String subscription; | ||
| private final NavigableMap<PositionImpl, ReplicatedSubscriptionsSnapshot> snapshots; | ||
| private final int maxSnapshotToCache; | ||
|
|
||
| public ReplicatedSubscriptionSnapshotCache(String subscription, int maxSnapshotToCache) { | ||
| this.subscription = subscription; | ||
| this.snapshots = new TreeMap<>(); | ||
| this.maxSnapshotToCache = maxSnapshotToCache; | ||
| } | ||
|
|
||
| public synchronized void addNewSnapshot(ReplicatedSubscriptionsSnapshot snapshot) { | ||
| MessageIdData msgId = snapshot.getLocalMessageId(); | ||
| PositionImpl position = new PositionImpl(msgId.getLedgerId(), msgId.getEntryId()); | ||
|
|
||
| if (log.isDebugEnabled()) { | ||
| log.debug("[{}] Added new replicated-subscription snapshot at {} -- {}", subscription, position, | ||
| snapshot.getSnapshotId()); | ||
| } | ||
|
|
||
| snapshots.put(position, snapshot); | ||
|
|
||
| // Prune the cache | ||
| while (snapshots.size() > maxSnapshotToCache) { | ||
| snapshots.pollFirstEntry(); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Signal that the mark-delete position on the subscription has been advanced. If there is a snapshot that | ||
| * correspond to this position, it will returned, other it will return null. | ||
| */ | ||
| public synchronized ReplicatedSubscriptionsSnapshot advancedMarkDeletePosition(PositionImpl pos) { | ||
| ReplicatedSubscriptionsSnapshot snapshot = null; | ||
| while (!snapshots.isEmpty()) { | ||
| PositionImpl first = snapshots.firstKey(); | ||
| if (first.compareTo(pos) > 0) { | ||
| // Snapshot is associated which an higher position, so it cannot be used now | ||
| break; | ||
| } else { | ||
| // This snapshot is potentially good. Continue the search for to see if there is a higher snapshot we | ||
| // can use | ||
| snapshot = snapshots.pollFirstEntry().getValue(); | ||
| } | ||
| } | ||
|
|
||
| if (log.isDebugEnabled()) { | ||
| if (snapshot != null) { | ||
| log.debug("[{}] Advanced mark-delete position to {} -- found snapshot {} at {}:{}", subscription, pos, | ||
| snapshot.getSnapshotId(), | ||
| snapshot.getLocalMessageId().getLedgerId(), | ||
| snapshot.getLocalMessageId().getEntryId()); | ||
| } else { | ||
| log.debug("[{}] Advanced mark-delete position to {} -- snapshot not found", subscription, pos); | ||
| } | ||
| } | ||
| return snapshot; | ||
| } | ||
| } |
Oops, something went wrong.