Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReflectionFactory is internal proprietary API and may be removed #683

Closed
maskit opened this issue Aug 12, 2017 · 6 comments · Fixed by #7582
Closed

ReflectionFactory is internal proprietary API and may be removed #683

maskit opened this issue Aug 12, 2017 · 6 comments · Fixed by #7582

Comments

@maskit
Copy link
Member

maskit commented Aug 12, 2017

Expected behavior

No warnings during build

Actual behavior

[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ managed-ledger ---
[INFO] Compiling 30 source files to /Users/masakazu/git/pulsar/managed-ledger/target/test-classes
[WARNING] /Users/masakazu/git/pulsar/managed-ledger/src/test/java/org/apache/zookeeper/MockZooKeeper.java:[81,23] ReflectionFactory is internal proprietary API and may be removed in a future release
[WARNING] /Users/masakazu/git/pulsar/managed-ledger/src/test/java/org/apache/zookeeper/MockZooKeeper.java:[81,58] ReflectionFactory is internal proprietary API and may be removed in a future release

Steps to reproduce

mvn install -DskipTests

System configuration

Pulsar version: master c51eaad
OS: macOS 10.12

@merlimat
Copy link
Contributor

I haven't found a way to fix this. We are using the ReflectionFactory in tests to instantiate a Zookeeper client instance without invoking the constructor (in the MockZookeeper).

Not calling the constructor is critical because Zookeeper class is trying to do many thing (like connecting) from the constructor and there is no other interface.

@sijie
Copy link
Member

sijie commented Nov 21, 2018

@merlimat is this related to your recent changes for java11?

@merlimat
Copy link
Contributor

@sijie Yes, I think it would still be required to be fixed. In #3006 I just verified it compiles and run with Java 11 though I haven't ran the tests with that yet.

@vcottagiri
Copy link
Contributor

@sijie - Let me look into this one

@sijie
Copy link
Member

sijie commented Jul 17, 2020

@vcottagiri great!

vcottagiri added a commit to vcottagiri/pulsar that referenced this issue Jul 17, 2020
vcottagiri added a commit to vcottagiri/pulsar that referenced this issue Jul 17, 2020
vcottagiri added a commit to vcottagiri/pulsar that referenced this issue Jul 17, 2020
vcottagiri added a commit to vcottagiri/pulsar that referenced this issue Jul 17, 2020
@vcottagiri
Copy link
Contributor

@sijie - thanks. Raised PR. Hope its what @merlimat was looking for.

vcottagiri added a commit to vcottagiri/pulsar that referenced this issue Jul 17, 2020
merlimat pushed a commit that referenced this issue Jul 17, 2020
… with Objenesis API (#7582)

* #683 - Replace internal proprietary API sun.reflect.ReflectionFactory with Objenisis API

* #683 - Replace internal proprietary API sun.reflect.ReflectionFactory with Objenisis API

* #683 - Replace deprecated KeeperException.Code constant references with corresponding enums

* #683 - Fixed pom header formatting

* #683 - Made objenesis variable a static final member variable
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this issue Aug 24, 2020
…ry API with Objenesis API (apache#7582)

* apache#683 - Replace internal proprietary API sun.reflect.ReflectionFactory with Objenisis API

* apache#683 - Replace internal proprietary API sun.reflect.ReflectionFactory with Objenisis API

* apache#683 - Replace deprecated KeeperException.Code constant references with corresponding enums

* apache#683 - Fixed pom header formatting

* apache#683 - Made objenesis variable a static final member variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants